linux-kernel - Re: [PATCH rebased] Use the new sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0710231530300.30120@woody.linux-foundation.org>
Date:	Tue, 23 Oct 2007 15:32:20 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Emil Medve <Emilian.Medve@...escale.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [PATCH rebased] Use the new sg_page() helper



On Tue, 23 Oct 2007, Emil Medve wrote:
>  
> -		sg->dma_address = page_to_phys(sg->page) + sg->offset;
> +		sg->dma_address = page_to_phys(sg_page(sg)) + sg->offset;

This is "sg_phys(sg)"

> -		consistent_sync(page_address(sg->page) + sg->offset,
> +		consistent_sync(page_address(sg_page(sg)) + sg->offset,
> -		consistent_sync(page_address(sg->page) + sg->offset,
> +		consistent_sync(page_address(sg_page(sg)) + sg->offset,
> -		consistent_sync(page_address(sg->page) + sg->offset,
> +		consistent_sync(page_address(sg_page(sg)) + sg->offset,

Please write "page_address(sg_page(sg)) + sg->offset" as "sg_virt(sg)" 
instead.

And send the patch to Jens, since he's the person who is in charge of 
getting this all sorted out ;)

Ok?

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/