linux-kernel - Re: [PATCH 2/12] X86: fix nvidia HPET warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <471EE0A9.2040008@garzik.org>
Date:	Wed, 24 Oct 2007 02:05:29 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	tglx@...utronix.de
Subject: Re: [PATCH 2/12] X86: fix nvidia HPET warning

Jeremy Fitzhardinge wrote:
> Jeff Garzik wrote:
>> arch/x86/kernel/early-quirks.c:40: warning: ‘nvidia_hpet_check’ defined but not used
>>
>> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
>> ---
>>
>> diff --git a/arch/x86/kernel/early-quirks.c b/arch/x86/kernel/early-quirks.c
>> index dc34acb..639e632 100644
>> --- a/arch/x86/kernel/early-quirks.c
>> +++ b/arch/x86/kernel/early-quirks.c
>> @@ -35,12 +35,14 @@ static void __init via_bugs(void)
>>  }
>>  
>>  #ifdef CONFIG_ACPI
>> +#ifdef CONFIG_X86_IO_APIC
>>   
> 
> Why not #if defined(CONFIG_ACPI) && defined(CONFIG_X86_IO_APIC)?  Saves
> a line and a layer of #if(def).

quite agreed, but I was merely duplicating (with precision :)) the 
ifdef-ery used in the caller

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/