linux-kernel - Re: [PATCH 4/12] riscom8: fix SMP brokenness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Oct 2007 08:47:23 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org
Subject: Re: [PATCH 4/12] riscom8: fix SMP brokenness

On 10/24/2007 12:36 AM, Jeff Garzik wrote:
> After analyzing the elements that save_flags/cli/sti/restore_flags were
> protecting, convert their usages to a global spinlock (the easiest and
> most obvious next-step).  There were some usages of flags being
> intentionally cached, because the code already knew the state of
> interrupts.  These have been taken into account.
> 
> This allows us to remove CONFIG_BROKEN_ON_SMP.  Completely untested.
> 
> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
> ---
> 
[...]
> diff --git a/drivers/char/riscom8.c b/drivers/char/riscom8.c
> index b37e626..45d109c 100644
> --- a/drivers/char/riscom8.c
> +++ b/drivers/char/riscom8.c
[...]
> @@ -82,6 +83,8 @@
>  static struct riscom_board * IRQ_to_board[16];
>  static struct tty_driver *riscom_driver;
>  
> +static spinlock_t riscom_lock = SPIN_LOCK_UNLOCKED;

This is deprecated (see linux/spinlock_types.h for details), use DEFINE_SPINLOCK
instead, otherwise seems OK.

Revieweved-by: Jiri Slaby <jirislaby@...il.com>

thanks,
-- 
Jiri Slaby (jirislaby@...il.com)
Faculty of Informatics, Masaryk University
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/