lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20071024011535.GZ30533@stusta.de> Date: Wed, 24 Oct 2007 03:15:35 +0200 From: Adrian Bunk <bunk@...nel.org> To: Jeff Garzik <jeff@...zik.org> Cc: David Miller <davem@...emloft.net>, davej@...hat.com, auke-jan.h.kok@...el.com, ajax@...hat.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] e1000, e1000e valid-addr fixes On Tue, Oct 23, 2007 at 08:55:29PM -0400, Jeff Garzik wrote: > Actually, looking over the code I see obvious bugs in the logic: > > An invalid ethernet address should not cause device loading to fail, > because the user is given the opportunity to supply a MAC address via > userspace (ifconfig or whatever) before the interface goes up. > > I just created the attached -bug fix- patch as illustration, though I have > not committed it, waiting for comment. >... Is there a good reason why we have such checks duplicated in the drivers (with every driver doing it differently...) instead of doing it in net/core/dev.c? > Jeff cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists