[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <471F03F5.7090608@qumranet.com>
Date: Wed, 24 Oct 2007 10:36:05 +0200
From: Avi Kivity <avi@...ranet.com>
To: Jeff Garzik <jeff@...zik.org>
CC: Adrian Bunk <bunk@...nel.org>, LKML <linux-kernel@...r.kernel.org>,
akpm@...ux-foundation.org
Subject: Re: [PATCH 6/12] KVM: work around SMP requirement
Jeff Garzik wrote:
> Adrian Bunk wrote:
>> On Tue, Oct 23, 2007 at 06:36:40PM -0400, Jeff Garzik wrote:
>>> KVM is currently completely broken for the !CONFIG_SMP case.
>>>
>>> drivers/kvm/kvm_main.c: In function ‘kvm_flush_remote_tlbs’:
>>> drivers/kvm/kvm_main.c:220: error: implicit declaration of function
>>> ‘smp_call_function_mask’
>>>
>>> Signed-off-by: Jeff Garzik <jgarzik@...hat.com>
>>> ---
>>> I hope the KVM maintainer can come up with a better solution...
>>>
>>> diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig
>>> index 8749fa4..e35fbc6 100644
>>> --- a/drivers/kvm/Kconfig
>>> +++ b/drivers/kvm/Kconfig
>>> @@ -16,7 +16,7 @@ if VIRTUALIZATION
>>>
>>> config KVM
>>> tristate "Kernel-based Virtual Machine (KVM) support"
>>> - depends on X86 && EXPERIMENTAL
>>> + depends on X86 && EXPERIMENTAL && SMP
>>> ...
>>
>> Assuming it won't get fixed soon, the pattern would be "(SMP ||
>> BROKEN)".
>>
>> The effect is the same, but this makes it more obvious that KVM does
>> not depend architecturally on SMP but just broken.
>>
>> Of course, the preferred solution is to simply get KVM fixed...
>
> In general I agree, but I specifically avoided CONFIG_BROKEN in case
> it was an intentional choice to require an SMP kernel.
>
Of course SMP is not required. I'll submit a patch to make
smp_call_function_mask() available on UP kernels. Andrew, please don't
apply the KVM Kconfig patch.
--
error compiling committee.c: too many arguments to function
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists