linux-kernel - Re: [PATCH] watchdog: add Nano 7240 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071024152240.GB6015@infomag.infomag.iguana.be>
Date:	Wed, 24 Oct 2007 17:22:40 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Gilles Gigan <gilles.gigan@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: add Nano 7240 driver

Hi Andrew,

> > +	case WDIOC_SETOPTIONS:{
> > +			int retval = -EINVAL;
> > +
> > +			if (arg & WDIOS_DISABLECARD) {
> > +				wdt_disable();
> > +				retval = 0;
> > +			}
> > +
> > +			if (arg & WDIOS_ENABLECARD) {
> > +				wdt_enable();
> > +				retval = 0;
> > +			}
> > +
> > +			return retval;
> 
> hrm.  So if userspace does ioctl(..., WDIOS_DISABLECARD|WDIOS_ENABLECARD,
> that happens to be equivalent to WDIOS_ENABLECARD?
> 
> Do all watchdog drivers do it exactly the same way, or are we offering
> inconsistent interfaces between different drivers?

I fear that all watchdog drivers do it more or less like this.

I'll have a look at it later on.

Greetings,
Wim.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/