linux-kernel - Re: [2.6 patch] #if 0 cpufreq.c:cpufreq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071024164616.GY30533@stusta.de>
Date:	Wed, 24 Oct 2007 18:46:16 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Russell King <rmk+lkml@....linux.org.uk>
Cc:	Thomas Gleixner <tglx@...utronix.de>, davej@...emonkey.org.uk,
	cpufreq@...ts.linux.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] #if 0 cpufreq.c:cpufreq_get()

On Wed, Oct 24, 2007 at 05:32:45PM +0100, Russell King wrote:
> On Wed, Oct 24, 2007 at 06:23:12PM +0200, Adrian Bunk wrote:
> > cpufreq.c:cpufreq_get() no longer has any user.
> 
> Your checking seems to be flawed.
> 
> drivers/video/sa1100fb.c:               cpufreq_get(smp_processor_id()));
> drivers/video/sa1100fb.c:       pcd = get_pcd(var->pixclock, cpufreq_get(0));

Thanks for spotting this.

My mistake was that I thought this was handled by the following without 
checking closer:

arch/arm/mach-sa1100/generic.c:unsigned int cpufreq_get(unsigned int cpu)
arch/arm/mach-sa1100/generic.c:EXPORT_SYMBOL(cpufreq_get);

> Russell King

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/