lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 23 Oct 2007 20:55:29 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	David Miller <davem@...emloft.net>
CC:	davej@...hat.com, auke-jan.h.kok@...el.com, ajax@...hat.com,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: [PATCH] e1000, e1000e valid-addr fixes

Actually, looking over the code I see obvious bugs in the logic:

An invalid ethernet address should not cause device loading to fail, 
because the user is given the opportunity to supply a MAC address via 
userspace (ifconfig or whatever) before the interface goes up.

I just created the attached -bug fix- patch as illustration, though I 
have not committed it, waiting for comment.

This patch will make no difference for users hitting invalid-eep-csum 
rather than invalid-MAC-addr condition, but it's a problem I noticed 
while reviewing Adam's patch in detail.

	Jeff





View attachment "patch.e1000-addr" of type "text/plain" (3741 bytes)

Powered by blists - more mailing lists