linux-kernel - Re: [PATCH] De-constify sched.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071026.025029.00497274.davem@davemloft.net>
Date:	Fri, 26 Oct 2007 02:50:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	rientjes@...gle.com
Cc:	adobriyan@...ru, torvalds@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] De-constify sched.h

From: David Rientjes <rientjes@...gle.com>
Date: Fri, 26 Oct 2007 02:42:30 -0700 (PDT)

> On Fri, 26 Oct 2007, Alexey Dobriyan wrote:
> 
> > 2) There is no such thing as const task_struct. Anyone who think otherwise
> >    deserves compiler warning.
> > 
> 
> A 'const struct task_struct *' can be used as an annotation to mean that 
> no member of the struct is modified through that pointer, so it's 
> perfectly acceptable to qualify formals in that manner.

But in one of the cases he un-const's the code does modify
the object through the pointer.  At least that one should
be reverted since the annotation is wrong.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/