linux-kernel - Re: [RFC PATCH 0/2] Fix linux/swap.h build wart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071026214910.GA11112@c2.user-mode-linux.org>
Date:	Fri, 26 Oct 2007 17:49:10 -0400
From:	Jeff Dike <jdike@...toit.com>
To:	"Luck, Tony" <tony.luck@...el.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [RFC PATCH 0/2] Fix linux/swap.h build wart

On Fri, Oct 26, 2007 at 01:38:12PM -0700, Luck, Tony wrote:
> Not fundamental reasons, but these patches break the ia64 build for most
> configs with:
> 
> In file included from kernel/futex.c:59:
> include/asm/futex.h: In function `futex_atomic_op_inuser':
> include/asm/futex.h:62: error: implicit declaration of function `pagefault_disable'
> include/asm/futex.h:86: error: implicit declaration of function `pagefault_enable'
> make[1]: *** [kernel/futex.o] Error 1
> 
> Adding an include of <linux/uaccess.h> to kernel/futex.c is sufficient (but
> not necessarily right) to unbreak this.

Yeah, I've been changing <asm/uaccess.h> to <linux/uaccess.h> for
these.  Looks like I'll need to make a pass over all the futex.h's.

> A few configs also fail with:
> mm/migrate.c: In function `migrate_page_copy':
> mm/migrate.c:359: error: implicit declaration of function `copy_highpage'
> make[1]: *** [mm/migrate.o] Error 1
> 
> Making mm/migrate.c include <linux/highmem.h> fixes this one.

Excellent, I hadn't yet figured out who used migrate.c.

				Jeff

-- 
Work email - jdike at linux dot intel dot com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/