lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <617E1C2C70743745A92448908E030B2A02C9D4B6@scsmsx411.amr.corp.intel.com> Date: Fri, 26 Oct 2007 13:38:12 -0700 From: "Luck, Tony" <tony.luck@...el.com> To: "Jeff Dike" <jdike@...toit.com>, "LKML" <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>, <linux-arch@...r.kernel.org> Subject: RE: [RFC PATCH 0/2] Fix linux/swap.h build wart > These patches propose to break the recursion instead by removing the > linux/pagemap.h -> linux/highmem.h inclusion. I'd like to know > whether there are any fundamental reasons that this include should be > preserved. Not fundamental reasons, but these patches break the ia64 build for most configs with: In file included from kernel/futex.c:59: include/asm/futex.h: In function `futex_atomic_op_inuser': include/asm/futex.h:62: error: implicit declaration of function `pagefault_disable' include/asm/futex.h:86: error: implicit declaration of function `pagefault_enable' make[1]: *** [kernel/futex.o] Error 1 Adding an include of <linux/uaccess.h> to kernel/futex.c is sufficient (but not necessarily right) to unbreak this. A few configs also fail with: mm/migrate.c: In function `migrate_page_copy': mm/migrate.c:359: error: implicit declaration of function `copy_highpage' make[1]: *** [mm/migrate.o] Error 1 Making mm/migrate.c include <linux/highmem.h> fixes this one. -Tony - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists