linux-kernel - Re: [PATCH 7/9] irq-remove: scsi driver trivial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47228278.8070505@garzik.org>
Date:	Fri, 26 Oct 2007 20:12:40 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Arjan van de Ven <arjan@...radead.org>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"Salyzyn, Mark" <mark_salyzyn@...ptec.com>,
	linux-kernel@...r.kernel.org, ebiederm@...ssion.com
Subject: Re: [PATCH 7/9] irq-remove: scsi driver trivial

Arjan van de Ven wrote:
> On Fri, 26 Oct 2007 17:47:58 -0400
> Jeff Garzik <jeff@...zik.org> wrote:
> 
>> Andrew Morton wrote:
>>> That was a goofup.  I proposed that we should add a #define
>>> TWO_ARG_IRQ_HANDLERS (or whatever) and I think I actually wrote the
>>> patch, but it got lost.
>>>
>>> I agree it would be a kind thing to do in this case.
> 
>>
>> Yep, I was thinking that including
>>
>> 	#define IRQ_HANDLER_V3
>>
>> would be a good idea.
>>
> 
> it sets a certain precedent though.... we don't do this for the 500
> other API changes we do each release (see stable-api-nonsense)... so
> this one is mostly arbitrary picked out

We do for include/linux/netdevice.h, see HAVE_xxx -- and we should do it 
because the last irq handler change was a pain for backports, and this 
makes life easier for the backporters.  irq handling is probably far 
more global than any other kernel API except kmalloc()

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/