linux-kernel - Re: [PATCH] usbserial: fix inconsistent lock state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0710281543260.12935@jikos.suse.cz>
Date:	Sun, 28 Oct 2007 15:45:26 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Borislav Petkov <bbpetkov@...oo.de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usbserial: fix inconsistent lock state

On Sun, 28 Oct 2007, Borislav Petkov wrote:

> ---
> In commit acd2a847e7fee7df11817f67dba75a2802793e5d usb_serial_generic_write()
> disables interrupts when taking &port->lock which is also taken in
> usb_serial_generic_read_bulk_callback() resulting in an inconsistent lock state
> due to the latter not disabling interrupts on the local cpu. Fix that by
> disabling interrupts in the latter call site also.
> Signed-off-by: Borislav Petkov <bbpetkov@...oo.de>

You are right, I missed the usb_serial_generic_read_bulk_callback() one, 
thanks for catching this.

	Acked-by: Jiri Kosina <jkosina@...e.cz>

-- 
Jiri Kosina
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/