linux-kernel - Re: [build bug, 2.6.24-rc1] CONFIG_VIDEO_DEV=m & CONFIG_VIDEO_SAA7146

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071029112303.GA18994@elte.hu>
Date:	Mon, 29 Oct 2007 12:23:03 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Johannes Stezenbach <js@...uxtv.org>,
	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [build bug, 2.6.24-rc1] CONFIG_VIDEO_DEV=m &
	CONFIG_VIDEO_SAA7146_VV=y


* Randy Dunlap <randy.dunlap@...cle.com> wrote:

> > config VIDEO_SAA7146_VV
> > 	tristate
> > 	depends on VIDEO_DEV = y || VIDEO_DEV = VIDEO_SAA7146_VV
> > 	select VIDEOBUF_DMA_SG
> > 	select VIDEO_SAA7146
> > 
> > (untested)
> 
> Nope, won't work.  I tried that last night.  VIDEO_DEV_SAA7146_VV
> has too many "select"s involved, but select doesn't follow the dependency
> chains.  IOW, as written in Documentation/kbuild/kconfig-language.txt:
> 
> 	select is evil.... select will by brute force set a symbol
> 	equal to 'y' without visiting the dependencies. So abusing
> 	select you are able to select a symbol FOO even if FOO depends
> 	on BAR that is not set.

so ... what should we do? Remove those ~7 select VIDEO_SAA7146_VV lines 
and replace them with depends on VIDEO_SAA7146_VV ?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/