linux-kernel - Re: [PATCH-RESEND] Re: S390 change in sg_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071029112617.GB5001@kernel.dk>
Date:	Mon, 29 Oct 2007 12:26:18 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, linux-s390@...r.kernel.org
Subject: Re: [PATCH-RESEND] Re: S390 change in sg_set_page() cause build
	failure

On Mon, Oct 29 2007, Kamalesh Babulal wrote:
> On Fri, Oct 26, 2007 at 01:54:30PM +0200, Jens Axboe wrote:
> > On Fri, Oct 26 2007, Kamalesh Babulal wrote:
> > > Hi Jens,
> > > 
> > >  	sg_set_buf(list, address, 0);
> <snip>
> > >  }
> > 
> > That's not quite right, it should be:
> > 
> > diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
> > index 0754542..e268f79 100644
> > --- a/drivers/s390/scsi/zfcp_def.h
> > +++ b/drivers/s390/scsi/zfcp_def.h
> > @@ -70,11 +70,12 @@ zfcp_sg_to_address(struct scatterlist *list)
> >   * zfcp_address_to_sg - set up struct scatterlist from kernel address
> >   * @address: kernel address
> >   * @list: struct scatterlist
> > + * @size: buffer size
> >   */
> >  static inline void
> > -zfcp_address_to_sg(void *address, struct scatterlist *list)
> > +zfcp_address_to_sg(void *address, struct scatterlist *list, unsigned int size)
> >  {
> > -	sg_set_buf(list, address, 0);
> > +	sg_set_buf(list, address, size);
> >  }
> > 
> >  #define REQUEST_LIST_SIZE 128
> > 
> > -- 
> > Jens Axboe
> 
> Hi Jens,
> 
> Resending the patch with the changes pointed by you in the patch.
> 
> [jens.axboe@...cle.com: size parameter fix]
> Signed-off-by: Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
> --
> diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h
> index 0754542..f747e86 100644
> --- a/drivers/s390/scsi/zfcp_def.h
> +++ b/drivers/s390/scsi/zfcp_def.h
> @@ -70,11 +70,12 @@ zfcp_sg_to_address(struct scatterlist *list)
>   * zfcp_address_to_sg - set up struct scatterlist from kernel address
>   * @address: kernel address
>   * @list: struct scatterlist
> + * @size: buffer size 
>   */
>  static inline void
> -zfcp_address_to_sg(void *address, struct scatterlist *list)
> +zfcp_address_to_sg(void *address, struct scatterlist *list, unsigned int size)
>  {
> -	sg_set_buf(list, address, 0);
> +	sg_set_buf(list, address, size);
>  }
>  
>  #define REQUEST_LIST_SIZE 128

Thanks Kamalesh, but I already merged a fixed up version on friday:

http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=9335432959111c982c74177521305e6a3fb600a3

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/