linux-kernel - Re: [linux-usb-devel] [RFC: 2.6 patch] remove the USB_STORAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0710291017520.4550-100000@iolanthe.rowland.org>
Date:	Mon, 29 Oct 2007 10:22:03 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Dmitry Torokhov <dtor@...ightbb.com>
cc:	linux-input@...ey.karlin.mff.cuni.cz,
	Adrian Bunk <bunk@...nel.org>,
	<linux-usb-devel@...ts.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	<linux-kernel@...r.kernel.org>, Nick Sillik <n.sillik@...ple.edu>,
	David Brownell <david-b@...bell.net>,
	Torsten Kaiser <just.for.lkml@...glemail.com>
Subject: Re: [linux-usb-devel] [RFC: 2.6 patch] remove the USB_STORAGE_ONETOUCH
 driver

On Sun, 28 Oct 2007, Dmitry Torokhov wrote:

> On Sunday 28 October 2007 16:39, Jiri Kosina wrote:
> > On Sun, 28 Oct 2007, Torsten Kaiser wrote:
> > 
> > > But it looks like that uses another driver:
> > > hiddev0hidraw1: USB HID v1.10 Device [Western Digital External HDD] on
> > > usb-0000:00:02.1-5.2
> > > Otherwise I would be willing to try to test this, if someone would tell 
> > > me how to check that the second commit did fix the suspend problem.
> > 
> > If you need to unbind usbhid driver from the device and bind another one, 
> > you can use the 'unbind' and 'bind' files in sysfs.
> > 
> > As soon as the driver you are willing to test is bound to the device, you 
> > can go ahead with testing any functionality you wish (probably 
> > suspend/resume cycle is needed here?).
> > 
> > If the device is claimed by usbhid driver (because its descriptor probably 
> > states that it's HID-compliant device) and should be claimed by another 
> > driver, it's necessary to add it to usbhid blacklist -- just let me know.
> > 
> 
> Maybe onetouch driver is not needed after all. I wonder what key/button does
> HID deriver reports when it binds to it... Torsten, could you please post
> your /proc/bus/input/devices?

You guys all sound confused about this.

The original reason writing for the onetouch driver was because the
button on this disk drive isn't an HID device!  That is, the drive
doesn't include any of the usual HID descriptors for the button and the
button doesn't send HID-style reports.

Torsten's assessment was correct.  Originally there was no PM support 
for the onetouch driver.  Now there is (although it isn't very good), 
so it would be legitimate to remove the !PM condition.

As far as I know, the only person who ever used the onetouch driver was 
its author.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/