linux-kernel - Re: [linux-usb-devel] [PATCH 1/2] usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0710291509060.11831-100000@iolanthe.rowland.org>
Date:	Mon, 29 Oct 2007 15:10:51 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Tilman Schmidt <tilman@...p.cc>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-kernel@...r.kernel.org>, Greg KH <gregkh@...e.de>,
	<linux-usb-devel@...ts.sourceforge.net>,
	Hansjoerg Lipp <hjlipp@....de>, Karsten Keil <kkeil@...e.de>,
	<i4ldeveloper@...tserv.isdn4linux.de>
Subject: Re: [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support

On Mon, 29 Oct 2007, Tilman Schmidt wrote:

> From: Tilman Schmidt <tilman@...p.cc>
> 
> Add basic suspend/resume support to the usb_gigaset driver.

> @@ -117,6 +122,11 @@ static struct usb_driver gigaset_usb_dri
>  	.probe =	gigaset_probe,
>  	.disconnect =	gigaset_disconnect,
>  	.id_table =	gigaset_table,
> +	.suspend =	gigaset_suspend,
> +	.resume =	gigaset_resume,
> +	.reset_resume =	gigaset_resume,
> +	.pre_reset =	gigaset_suspend,
> +	.post_reset =	gigaset_resume,
>  };

Does this really compile?  The .pre_reset and .suspend members are 
pointers to functions with different prototypes; I don't see how you 
can assign the same function to both pointers.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/