linux-kernel - Re: [linux-usb-devel] [PATCH 1/2] usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47264E93.2040009@imap.cc>
Date:	Mon, 29 Oct 2007 22:20:19 +0100
From:	Tilman Schmidt <tilman@...p.cc>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Greg KH <gregkh@...e.de>,
	linux-usb-devel@...ts.sourceforge.net,
	Hansjoerg Lipp <hjlipp@....de>, Karsten Keil <kkeil@...e.de>,
	i4ldeveloper@...tserv.isdn4linux.de
Subject: Re: [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support

Am 29.10.2007 20:10 schrieb Alan Stern:
> On Mon, 29 Oct 2007, Tilman Schmidt wrote:
> 
>> From: Tilman Schmidt <tilman@...p.cc>
>>
>> Add basic suspend/resume support to the usb_gigaset driver.
> 
>> @@ -117,6 +122,11 @@ static struct usb_driver gigaset_usb_dri
>>  	.probe =	gigaset_probe,
>>  	.disconnect =	gigaset_disconnect,
>>  	.id_table =	gigaset_table,
>> +	.suspend =	gigaset_suspend,
>> +	.resume =	gigaset_resume,
>> +	.reset_resume =	gigaset_resume,
>> +	.pre_reset =	gigaset_suspend,
>> +	.post_reset =	gigaset_resume,
>>  };
> 
> Does this really compile?  The .pre_reset and .suspend members are 
> pointers to functions with different prototypes; I don't see how you 
> can assign the same function to both pointers.

Oops, you're right. Yes, it does compile, but with a warning
"initialization from incompatible pointer type" which I
foolishly ignored.

I'll produce a corrected version promptly.

Thanks,
Tilman

-- 
Tilman Schmidt                          E-Mail: tilman@...p.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)


Download attachment "signature.asc" of type "application/pgp-signature" (254 bytes)