[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47275FD0.4010400@student.ltu.se>
Date: Tue, 30 Oct 2007 17:46:08 +0100
From: Richard Knutsson <ricknu-0@...dent.ltu.se>
To: Matthew Wilcox <matthew@....cx>
CC: James.Bottomley@...elEye.com, linux-kernel@...r.kernel.org,
linux-scsi@...r.kernel.org
Subject: Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean
Matthew Wilcox wrote:
> On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote:
>
>> Matthew Wilcox wrote:
>>
>>> On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote:
>>>
>>>
>>>> Convert to use the generic boolean.
>>>> - u8 initialized;
>>>> - u8 in_use; /* is the management node open*/
>>>> + bool initialized:8;
>>>> + bool in_use:8; /* is the management node open*/
>>>>
>>>>
>>> Are you serious?
>>>
>>>
>> Well, yes. It is since it was defined to really be 8 bits before, and
>> there is no reason why a boolean would be 8 bits and not 1 or 16.
>> If it is overly cautious/not needed, then I don't mind removing the ':8'...
>>
>
> What's wrong with leaving it as 'u8'?
>
I just don't see the reason why expressing a boolean as an integer. Some
advantage?
(also helps us if someone does: 'if (var == true)', even thou we should
try to avoid them)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists