linux-kernel - Re: [patch 04/28] Add cmpxchg64 and cmpxchg64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 31 Oct 2007 12:48:31 +0000
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	matthew@....cx, linux-arch@...r.kernel.org, penberg@...helsinki.fi,
	linux-mm@...ck.org, Christoph Lameter <clameter@....com>
Subject: Re: [patch 04/28] Add cmpxchg64 and cmpxchg64_local to mips

On Tue, Oct 30, 2007 at 03:16:01PM -0400, Mathieu Desnoyers wrote:

> Index: linux-2.6-lttng/include/asm-mips/cmpxchg.h
> ===================================================================
> --- linux-2.6-lttng.orig/include/asm-mips/cmpxchg.h	2007-10-12 12:05:06.000000000 -0400
> +++ linux-2.6-lttng/include/asm-mips/cmpxchg.h	2007-10-12 12:08:56.000000000 -0400
> @@ -104,4 +104,13 @@ extern void __cmpxchg_called_with_bad_po
>  #define cmpxchg(ptr, old, new)		__cmpxchg(ptr, old, new, smp_llsc_mb())
>  #define cmpxchg_local(ptr, old, new)	__cmpxchg(ptr, old, new, )
>  
> +#define cmpxchg64	cmpxchg
> +
> +#ifdef CONFIG_64BIT
> +#define cmpxchg64_local	cmpxchg_local

This implementation means cmpxchg64_local will also silently take 32-bit
arguments without making noises at compile time.  I think it should.

  Ralf
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/