linux-kernel - Re: [patch 04/28] Add cmpxchg64 and cmpxchg64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071031131935.GA26625@Krystal>
Date:	Wed, 31 Oct 2007 09:19:35 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
To:	Ralf Baechle <ralf@...ux-mips.org>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	matthew@....cx, linux-arch@...r.kernel.org, penberg@...helsinki.fi,
	linux-mm@...ck.org, Christoph Lameter <clameter@....com>
Subject: Re: [patch 04/28] Add cmpxchg64 and cmpxchg64_local to mips

* Ralf Baechle (ralf@...ux-mips.org) wrote:
> This implementation means cmpxchg64_local will also silently take 32-bit
> arguments without making noises at compile time.  I think it should.
> 

Something along those lines ? I've fixed the other architectures too.


Add cmpxchg64 and cmpxchg64_local to mips

Make sure that at least cmpxchg64_local is available on all architectures to use
for unsigned long long values.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
CC: ralf@...ux-mips.org
CC linux-mips@...ux-mips.org
---
 include/asm-mips/cmpxchg.h |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Index: linux-2.6-lttng/include/asm-mips/cmpxchg.h
===================================================================
--- linux-2.6-lttng.orig/include/asm-mips/cmpxchg.h	2007-10-31 09:14:10.000000000 -0400
+++ linux-2.6-lttng/include/asm-mips/cmpxchg.h	2007-10-31 09:15:35.000000000 -0400
@@ -104,4 +104,21 @@ extern void __cmpxchg_called_with_bad_po
 #define cmpxchg(ptr, old, new)		__cmpxchg(ptr, old, new, smp_llsc_mb())
 #define cmpxchg_local(ptr, old, new)	__cmpxchg(ptr, old, new, )
 
+#define cmpxchg64(ptr,o,n)						\
+  ({									\
+  	BUILD_BUG_ON(sizeof(*(ptr)) != 8);				\
+  	cmpxchg((ptr),(o),(n));						\
+  })
+
+#ifdef CONFIG_64BIT
+#define cmpxchg64_local(ptr,o,n)					\
+  ({									\
+  	BUILD_BUG_ON(sizeof(*(ptr)) != 8);				\
+  	cmpxchg_local((ptr),(o),(n));					\
+  })
+#else
+#include <asm-generic/cmpxchg-local.h>
+#define cmpxchg64_local(ptr,o,n)	__cmpxchg64_local_generic((ptr),(o),(n))
+#endif
+
 #endif /* __ASM_CMPXCHG_H */

-- 
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/