linux-kernel - Re: [PATCH 2/2] Char: tty, add tty_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 Nov 2007 15:48:47 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] Char: tty, add tty_schedule_wakeup

On Thu,  1 Nov 2007 11:55:56 +0100 (CET)
Jiri Slaby <jirislaby@...il.com> wrote:

> tty, add tty_schedule_wakeup
> 
> Because several drivers schedule a workqueue only for tty_wakeup, move this
> functionality into tty layer and use newly added centralized work.

I've no idea why any drivers do this. A tty_wakeup is very fast and it
won't (when called from an IRQ) reschedule anything until the IRQ is over
(in the RT kernel case it might do stuff but thats *because* it should do
so).

I think just using tty_wakeup for this ought to be sufficient unless they
are using the work queue for some kind of serialization of events
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/