linux-kernel - Re: [PATCH] audit: clear thread flag for new children

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071101172324.GA3938@suse.de>
Date:	Thu, 1 Nov 2007 10:23:24 -0700
From:	Tony Jones <tonyj@...e.de>
To:	Steve Grubb <sgrubb@...hat.com>
Cc:	linux-audit@...hat.com, linux-kernel@...r.kernel.org,
	chrisw@...s-sol.org, viro@....linux.org.uk
Subject: Re: [PATCH] audit: clear thread flag for new children

On Thu, Nov 01, 2007 at 10:33:52AM -0400, Steve Grubb wrote:
> On Monday 29 October 2007 07:15:30 pm Tony Jones wrote:
> > On Mon, Oct 29, 2007 at 06:04:31PM -0400, Steve Grubb wrote:
> > > So when audit is re-enabled, how do you make that task auditable?
> >
> > No idea. How do you do it currently? HINT: current->audit_context == NULL
> > for these tasks.  If !audit_enabled, then audit_alloc() is not going to
> > allocate an audit_context for the task.
> 
> We are looking into this - at one time it did. Someone should follow up with 
> a path correcting this soon. But I doubt the audit system will work correctly 
> if the flag gets removed as there is no good way to add it again later.

So on the syscall path you're now going to something like (pseudocode):
if (unlikely(current->audit_context)) {audit_syscall_entry()} 
else if (audit_enabled) {audit_alloc(); audit_syscall_entry()}

I agree, if this is what you want to do, then clearing the thread flag would
be a bad idea.  I'd assumed the current behaviour was by design as allocating
contexts at syscall time doesn't seem a great idea but if you need the 
functionality, you need the functionality.

Tony
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/