linux-kernel - Re: [PATCH] Remove unused code from mm/tiny-shmem.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 2 Nov 2007 14:48:35 -0500
From:	Matt Mackall <mpm@...enic.com>
To:	Balbir Singh <balbir@...ux.vnet.ibm.com>
Cc:	linux-mm <linux-mm@...ck.org>, Adrian Bunk <bunk@...sta.de>,
	Hugh Dickins <hugh@...itas.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove unused code from mm/tiny-shmem.c

[resent due to damaged header]

On Fri, Nov 02, 2007 at 10:50:56PM +0530, Balbir Singh wrote:
> This code in mm/tiny-shmem.c is under #if 0, do we really need it? This
> patch removes it.
> 
> Signed-off-by: Balbir Singh <balbir@...ux.vnet.ibm.com>

Adrian added the #ifdefs in March, not sure why he didn't kill it outright.

Acked-by: Matt Mackall <mpm@...enic.com>

>  mm/tiny-shmem.c |   12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff -puN mm/tiny-shmem.c~remove-unused-code mm/tiny-shmem.c
> --- linux-2.6-latest/mm/tiny-shmem.c~remove-unused-code	2007-11-02 22:43:12.000000000 +0530
> +++ linux-2.6-latest-balbir/mm/tiny-shmem.c	2007-11-02 22:43:30.000000000 +0530
> @@ -121,18 +121,6 @@ int shmem_unuse(swp_entry_t entry, struc
>  	return 0;
>  }
>  
> -#if 0
> -int shmem_mmap(struct file *file, struct vm_area_struct *vma)
> -{
> -	file_accessed(file);
> -#ifndef CONFIG_MMU
> -	return ramfs_nommu_mmap(file, vma);
> -#else
> -	return 0;
> -#endif
> -}
> -#endif  /*  0  */
> -
>  #ifndef CONFIG_MMU
>  unsigned long shmem_get_unmapped_area(struct file *file,
>  				      unsigned long addr,

-- 
Mathematics is the supreme nostalgia of our time.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/