linux-kernel - Re: device struct bloat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1194259581.27652.418.camel@twins>
Date:	Mon, 05 Nov 2007 11:46:21 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Greg KH <greg@...ah.com>
Cc:	Stephen Hemminger <shemminger@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, apw <apw@...dowen.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: device struct bloat

On Sun, 2007-11-04 at 19:58 -0800, Greg KH wrote:
> On Sun, Nov 04, 2007 at 09:29:18PM +0100, Peter Zijlstra wrote:
> > 
> > On Sat, 2007-11-03 at 12:48 -0700, Stephen Hemminger wrote:
> > > The sizeof(struct device) is way too big, especially in the network device case.
> > > We want to support 1000's of device's and the change from class_device to
> > > net_device has caused needless bloat.
> > > 
> > > sizeof(struct device) = 272
> > > sizeof(struct class_device) = 92
> > >   * not the class_id in class_device could also be removed or changed to
> > >      a ptr, since it is redundant for net_devices.
> > 
> > The thing that surprised me most was that it contains a struct
> > semaphore, Greg, is that really needed?
> 
> Yes, it serializes bind and unbind stuff for the device.  There are
> comments about it in drivers/base/dd.c if you want to look into it.

Ah, that is not what I meant. My question was, why a semaphore, not a
mutex? Semaphores should not be used if at all possible - for one you
don't get lockdep checking your code.

/me converts the stuff over, and boots

Ah, that probably is the reason. This device tree is hard to annotate.
I'll try and think of something..

Anyway, Andy, could you make checkpatch whine on something like:
   ^\+[[::space:]]*struct semaphore




Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)