linux-kernel - Re: [PATCH] Forbid user to change file flags on quota files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jefxzlas0q.fsf@sykes.suse.de>
Date:	Mon, 05 Nov 2007 11:47:01 +0100
From:	Andreas Schwab <schwab@...e.de>
To:	Jan Kara <jack@...e.cz>
Cc:	Jan Engelhardt <jengelh@...putergmbh.de>,
	linux-kernel@...r.kernel.org,
	LIOU Payphone <lioupayphone@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Forbid user to change file flags on quota files

Jan Kara <jack@...e.cz> writes:

> On Fri 02-11-07 18:32:08, Jan Engelhardt wrote:
>> 
>> On Nov 1 2007 16:52, Jan Kara wrote:
>> 
>> >--- linux-2.6.24-rc1/fs/ext2/ioctl.c	2007-10-24 20:43:56.000000000 +0200
>> >+++ linux-2.6.24-rc1-1-forbid_setflags/fs/ext2/ioctl.c	2007-11-01 16:01:26.000000000 +0100
>> >@@ -47,6 +47,11 @@ int ext2_ioctl (struct inode * inode, st
>> > 			flags &= ~EXT2_DIRSYNC_FL;
>> > 
>> > 		mutex_lock(&inode->i_mutex);
>> >+		/* Is it quota file? Don't allow user mess with it */
>> 
>> "Do not allow user to mess with it".
>   I think both "allow user mess" and "allow user to mess" are possible,

I think it's either "to allow doing sth" or "to allow to do sth", but
"to allow do sth" looks definitely wrong to me.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@...e.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/