linux-kernel - Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0711060742100.15101@woody.linux-foundation.org>
Date:	Tue, 6 Nov 2007 07:53:08 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Kyle Moffett <mrmacman_g4@....com>
cc:	"Ahmed S. Darwish" <darwish.07@...il.com>,
	Adrian Bunk <bunk@...nel.org>,
	Casey Schaufler <casey@...aufler-ca.com>,
	akpm@...ux-foundation.org, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

On Tue, 6 Nov 2007, Kyle Moffett wrote:
> 
> Personally I think that isspace() accepting character 0xA0 is a bug

I think I agree with you. As far as the kernel is concerned, "isspace()" 
should just accept the obvious spaces (hardspace, tab, newline), and 
*perhaps* the VT/FF kind of things.

You should realize that the kernel <ctype.h> thing is *ancient*. It's 
basically there from v0.01, and while the really original one (I just 
checked) had all the non-ascii characters not trigger anything, it was 
converted to be latin1 in the 2.1.x timeframe.

That's a *loong* time ago. Way before UTF-8 and other things were really 
common.

So we should probably just make all the upper 128 bytes go back to "don't 
trigger anything in ctype.h" - they'd not be spaces, but they'd not be 
control characters or anything else either.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/