linux-kernel - Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071106224206.GN26163@stusta.de>
Date:	Tue, 6 Nov 2007 23:42:06 +0100
From:	Adrian Bunk <bunk@...nel.org>
To:	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
Cc:	pavel@....cz, torvalds@...ux-foundation.org, darwish.07@...il.com,
	casey@...aufler-ca.com, akpm@...ux-foundation.org,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, viro@....linux.org.uk
Subject: Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser

On Wed, Nov 07, 2007 at 12:27:04AM +0900, Tetsuo Handa wrote:
> Hello.
> 
> Adrian Bunk wrote:
> > The problem is that your code matches one byte, not one character.
> > 
> > More or less all userspace programs handle multi-byte UTF-8 characters 
> > just fine without bothering the user with the fact whether a character 
> > consists of one or more bytes.
> I understood what you are saying.
> 
> You are saying "a character" does not always consist of one byte,
> while I'm saying "a character" does always consist of one byte.
> 
> Yes, some userspace programs don't use strcmp()
> since strcmp() can't handle some encodings like UTF-16.
> But the kernel uses strcmp()
> since the VFS related functions can't handle encodings
> which contains '\0' in the pathname.
> VFS related functions assume that '\0' is end-of-string marker.
>...

The common case isn't UTF-16, it's UTF-8.

And UTF-8 is both quite common and doesn't have this problem with '\0'.

> > And users will try to use this \? for matching one character when 
> > writing a pattern that denies access.
> Yes, but since this string is handled by the *kernel*,
> I want users follow point of view of the kernel.

Users are used to deal with characters and hot having to bother with all 
the mess of different encodings.

Having patterns that describe rules to deny access in an LSM breaking 
this expectation is really a bad thing.

> Thanks.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/