linux-kernel - Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071106073821.GA12733@redhat.com>
Date:	Tue, 6 Nov 2007 02:38:21 -0500
From:	Dave Jones <davej@...hat.com>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig

On Sun, Nov 04, 2007 at 12:51:11AM +0100, Sam Ravnborg wrote:

 > @@ -26,7 +29,7 @@ config X86_ACPI_CPUFREQ
 >  config ELAN_CPUFREQ
 >  	tristate "AMD Elan SC400 and SC410"
 >  	select CPU_FREQ_TABLE
 > -	depends on X86_ELAN
 > +	depends on X86_32 && X86_ELAN
 >  	---help---
 >  	  This adds the CPUFreq driver for AMD Elan SC400 and SC410
 >  	  processors.
 > @@ -42,7 +45,7 @@ config ELAN_CPUFREQ
 >  config SC520_CPUFREQ
 >  	tristate "AMD Elan SC520"
 >  	select CPU_FREQ_TABLE
 > -	depends on X86_ELAN
 > +	depends on X86_32 && X86_ELAN
 >  	---help---
 >  	  This adds the CPUFreq driver for AMD Elan SC520 processor.

X86_ELAN should depend on X86_32 rather than adding this everywhere.

 >  config X86_POWERNOW_K7
 >  	tristate "AMD Mobile Athlon/Duron PowerNow!"
 >  	select CPU_FREQ_TABLE
 > +	depends on X86_32
 >  	help
 >  	  This adds the CPUFreq driver for mobile AMD K7 mobile processors.
 >  
 > @@ -76,23 +81,27 @@ config X86_POWERNOW_K7_ACPI
 >  	bool
 >  	depends on X86_POWERNOW_K7 && ACPI_PROCESSOR
 >  	depends on !(X86_POWERNOW_K7 = y && ACPI_PROCESSOR = m)
 > +	depends on X86_32
 >  	default y

This 2nd hunk shouldn't be necessary, as it depends on X86_POWERNOW_K7
which you just added the 32bit dependancy to. 

 >  config X86_SPEEDSTEP_RELAXED_CAP_CHECK
 >  	bool "Relaxed speedstep capability checks"
 > -	depends on (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
 > +	depends on X86_32 && (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)

Should also be unnecessary due to those items now being 32bit dependant.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/