[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071106081339.GA5687@uranus.ravnborg.org>
Date: Tue, 6 Nov 2007 09:13:39 +0100
From: Sam Ravnborg <sam@...nborg.org>
To: Dave Jones <davej@...hat.com>,
Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...hat.com>,
"H. Peter Anvin" <hpa@...or.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig
> > + depends on X86_32 && X86_ELAN
> > ---help---
> > This adds the CPUFreq driver for AMD Elan SC520 processor.
>
> X86_ELAN should depend on X86_32 rather than adding this everywhere.
...
> > bool
> > depends on X86_POWERNOW_K7 && ACPI_PROCESSOR
> > depends on !(X86_POWERNOW_K7 = y && ACPI_PROCESSOR = m)
> > + depends on X86_32
> > default y
>
> This 2nd hunk shouldn't be necessary, as it depends on X86_POWERNOW_K7
> which you just added the 32bit dependancy to.
>
> > config X86_SPEEDSTEP_RELAXED_CAP_CHECK
> > bool "Relaxed speedstep capability checks"
> > - depends on (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
> > + depends on X86_32 && (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
>
> Should also be unnecessary due to those items now being 32bit dependant.
In several cases the "depends on X86_32 were added not as a necessity
but just to make it obvious that a given symbol is 32 bit specific.
I can drop doing it this way if it is anyway obvious from the context.
Will try to do so in next patch-set, due tonigt if things goes OK.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists