linux-kernel - Re: [PATCH RFC 3/7] x86: clean up asm-x86/page*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d6222a80711080842i201cb431le966d5069d59db24@mail.gmail.com>
Date:	Thu, 8 Nov 2007 14:42:59 -0200
From:	"Glauber de Oliveira Costa" <glommer@...il.com>
To:	"Jeremy Fitzhardinge" <jeremy@...p.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, "Andi Kleen" <ak@...e.de>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"Zach Amsden" <zach@...are.com>,
	"Jeremy Fitzhardinge" <Jeremy.Fitzhardinge@...rix.com>
Subject: Re: [PATCH RFC 3/7] x86: clean up asm-x86/page*.h

On Nov 7, 2007 11:50 PM, Jeremy Fitzhardinge <jeremy@...p.org> wrote:
> +#define PAGETABLE_LEVELS       3
> +
> +typedef u64    pteval_t;
> +typedef u64    pmdval_t;
> +typedef u64    pudval_t;
> +typedef u64    pgdval_t;
> +

> -static inline unsigned long long native_pgd_val(pgd_t pgd)
> +static inline pgdval_t native_pgd_val(pgd_t pgd)
>  {
Maybe these kind of things, the typedef and native_xxx definitions can
go into the common header, after we define the PAGETABLE_LEVELS
constant?
I think the more goes into common headers, the better.

> -static inline pte_t native_make_pte(unsigned long long val)
> +static inline pte_t native_make_pte(pteval_t val)
>  {
>         return (pte_t) { .pte_low = val, .pte_high = (val >> 32) } ;
>  }
Although these make_xxx things can probably be just left here...


-- 
Glauber de Oliveira Costa.
"Free as in Freedom"
http://glommer.net

"The less confident you are, the more serious you have to act."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/