[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <473378B3.1090700@goop.org>
Date: Thu, 08 Nov 2007 12:59:31 -0800
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Glauber de Oliveira Costa <glommer@...il.com>
CC: LKML <linux-kernel@...r.kernel.org>, Andi Kleen <ak@...e.de>,
Ingo Molnar <mingo@...e.hu>,
Thomas Gleixner <tglx@...utronix.de>,
Zach Amsden <zach@...are.com>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>
Subject: Re: [PATCH RFC 3/7] x86: clean up asm-x86/page*.h
Glauber de Oliveira Costa wrote:
> On Nov 7, 2007 11:50 PM, Jeremy Fitzhardinge <jeremy@...p.org> wrote:
>
>> +#define PAGETABLE_LEVELS 3
>> +
>> +typedef u64 pteval_t;
>> +typedef u64 pmdval_t;
>> +typedef u64 pudval_t;
>> +typedef u64 pgdval_t;
>> +
>>
>
>
>> -static inline unsigned long long native_pgd_val(pgd_t pgd)
>> +static inline pgdval_t native_pgd_val(pgd_t pgd)
>> {
>>
> Maybe these kind of things, the typedef and native_xxx definitions can
> go into the common header, after we define the PAGETABLE_LEVELS
> constant?
> I think the more goes into common headers, the better.
>
You mean put them in a common header, but conditionally by #if
PAGETABLE_LEVELS? I don't think that would be much of an improvement;
it would just add more #ifs, which adds lines and conceptual
complexity. If you go that way, you may as well put everything in one
header wrapped in #ifs, but personally I don't think that would help.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists