[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071107192211.c1c22e97.akpm@linux-foundation.org>
Date: Wed, 7 Nov 2007 19:22:11 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: ebiederm@...ssion.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sysctl: Check length at deprecated_sysctl_warning.
> On Thu, 08 Nov 2007 11:57:26 +0900 Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp> wrote:
> Original patch assumed args->nlen < CTL_MAXNAME, but it can be false.
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
>
>
> --- linux-2.6.22-rc2.orig/kernel/sysctl.c 2007-11-08 10:38:17.000000000 +0900
> +++ linux-2.6.22-rc2/kernel/sysctl.c 2007-11-08 11:24:27.000000000 +0900
> @@ -2609,6 +2609,10 @@ static int deprecated_sysctl_warning(str
> int name[CTL_MAXNAME];
> int i;
>
> + /* Check args->nlen. */
> + if (args->nlen > CTL_MAXNAME)
> + return -EFAULT;
> +
> /* Read in the sysctl name for better debug message logging */
> for (i = 0; i < args->nlen; i++)
> if (get_user(name[i], args->name + i))
Well that would have been a nice roothole for someone. Thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists