linux-kernel - Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference semantics change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4732B2FB.6000007@gmail.com>
Date:	Thu, 08 Nov 2007 15:55:55 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Greg KH <gregkh@...e.de>
CC:	Peter Osterlund <petero2@...ia.com>,
	Thomas Maier <balagi@...tmail.de>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference	semantics
 change

Greg KH wrote:
> On Thu, Nov 08, 2007 at 11:27:16AM +0900, Tejun Heo wrote:
>> pkt_setup_dev() expects module reference to be held on invocation.
>> This used to be true for sysfs callbacks but not anymore.  Test and
>> grab module reference around pkt_setup_dev() in
>> class_pktcdvd_store_add().
>>
>> Signed-off-by: Tejun Heo <htejun@...il.com>
>> Acked-by: Peter Osterlund <petero2@...ia.com>
>> ---
>> Greg, can you please push this patch through your tree? 
>> Thanks a lot.
>>
>>  drivers/block/pktcdvd.c |    9 +++++++++
>>  1 file changed, 9 insertions(+)
> 
> Why through my tree?  I don't do block devices :)

Because it's a regression introduced by changes in sysfs?

> Shouldn't Jens or at least Andrew take it?

That's fine too.  Jens?

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/