[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20071108065926.GB5011@kernel.dk>
Date: Thu, 8 Nov 2007 07:59:26 +0100
From: Jens Axboe <jens.axboe@...cle.com>
To: Tejun Heo <htejun@...il.com>
Cc: Greg KH <gregkh@...e.de>, Peter Osterlund <petero2@...ia.com>,
Thomas Maier <balagi@...tmail.de>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pktcdvd: fix BUG caused by sysfs module reference
semantics change
On Thu, Nov 08 2007, Tejun Heo wrote:
> Greg KH wrote:
> > On Thu, Nov 08, 2007 at 11:27:16AM +0900, Tejun Heo wrote:
> >> pkt_setup_dev() expects module reference to be held on invocation.
> >> This used to be true for sysfs callbacks but not anymore. Test and
> >> grab module reference around pkt_setup_dev() in
> >> class_pktcdvd_store_add().
> >>
> >> Signed-off-by: Tejun Heo <htejun@...il.com>
> >> Acked-by: Peter Osterlund <petero2@...ia.com>
> >> ---
> >> Greg, can you please push this patch through your tree?
> >> Thanks a lot.
> >>
> >> drivers/block/pktcdvd.c | 9 +++++++++
> >> 1 file changed, 9 insertions(+)
> >
> > Why through my tree? I don't do block devices :)
>
> Because it's a regression introduced by changes in sysfs?
>
> > Shouldn't Jens or at least Andrew take it?
>
> That's fine too. Jens?
Sure, I'm pushing some stuff off today anyway.
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists