[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071109234111.73bdb0b0@the-village.bc.nu>
Date: Fri, 9 Nov 2007 23:41:11 +0000
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Jiri Slaby <jirislaby@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] Char: rocket, printk cleanup
> - printk(KERN_INFO "rp_do_receive(%d)...", ToRecv);
> + printk(KERN_INFO "rp_do_receive(%d)...\n", ToRecv);
The missing \n was intentional looking at the old code, and meant you got
a lot of trace per line for debugging. The KERN_ additions are the
breakage here.
We might as well just lose them, we have proper debuggers now and they
are useless with \n, and pretty useless without.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists