[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071108203640.340751ba.akpm@linux-foundation.org>
Date: Thu, 8 Nov 2007 20:36:40 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "Robert P. J. Day" <rpjday@...shcourse.ca>
Cc: linux-kernel@...r.kernel.org, matthew@....cx
Subject: Re: [PATCH] Add the macro to test if "exactly_one_bit_set" to
log2.h.
> On Tue, 6 Nov 2007 11:38:52 -0500 (EST) "Robert P. J. Day" <rpjday@...shcourse.ca> wrote:
>
> While this macro is defined in terms of "is_power_of_2" and is
> therefore functionally equivalent, the visual semantics are sometimes
> more appropriate for what is actually being tested.
>
This is gettig a bit anal, but I guess you're the is_power_of_2 maintainer.
> ---
>
> diff --git a/include/linux/log2.h b/include/linux/log2.h
> index c8cf5e8..d0d324e 100644
> --- a/include/linux/log2.h
> +++ b/include/linux/log2.h
> @@ -55,6 +55,12 @@ bool is_power_of_2(unsigned long n)
> }
>
> /*
> + * And for folks who want slightly different semantics ...
> + */
> +
> +#define exactly_one_bit_set is_power_of_2
And I'm the dont-code-in-cpp-when-you-could-code-in-C maintainer.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists