linux-kernel - Re: [PATCH] USB: power-management.txt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0711121435180.1567-100000@netrider.rowland.org>
Date:	Mon, 12 Nov 2007 14:42:19 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Tilman Schmidt <tilman@...p.cc>
cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	<linux-usb-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] USB: power-management.txt - disconnect clarification

On Mon, 12 Nov 2007, Tilman Schmidt wrote:

> From: Tilman Schmidt <tilman@...p.cc>
> 
> Add a paragraph to Documentation/usb/power-management.txt about the
> interaction between suspend and disconnect.
> 
> Signed-off-by: Tilman Schmidt <tilman@...p.cc>
> ---
> 
> --- linux-2.6/Documentation/usb/power-management.txt	2007-10-14 00:41:08.000000000 +0200
> +++ linux-2.6.24-rc2-work/Documentation/usb/power-management.txt	2007-11-12 10:27:30.000000000 +0100
> @@ -278,6 +278,12 @@
>  	(although the interfaces will be in the same altsettings as
>  	before the suspend).
>  
> +If the device is disconnected or powered down while it is suspended,
> +the disconnect method will be called instead of the resume or
> +reset_resume method.  This will also happen if the system is resumed
> +from hibernation, as the device could have been disconnected without
> +the system being able to detect it.
> +

I don't like the second sentence very much.  How about something like 
this instead:

+If the device is disconnected or powered down while it is suspended,
+the disconnect method will be called instead of the resume or
+reset_resume method.  This is also quite likely to happen when
+waking up from hibernation, as many systems do not maintain suspend
+current to the USB host controllers during hibernation.  (It's
+possible to work around the hibernation-forces-disconnect problem by
+using the USB-Persist facility, described in
+Documentation/usb/persist.txt.)

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/