[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20071112.142845.154035709.davem@davemloft.net>
Date: Mon, 12 Nov 2007 14:28:45 -0800 (PST)
From: David Miller <davem@...emloft.net>
To: auke-jan.h.kok@...el.com
Cc: joonwpark81@...il.com, netdev@...r.kernel.org,
djohnson+linux-kernel@...starentnetworks.com,
linux-kernel@...r.kernel.org, e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] [e1000 VLAN] Disable vlan hw accel when
promiscuous mode
From: "Kok, Auke" <auke-jan.h.kok@...el.com>
Date: Mon, 12 Nov 2007 09:12:40 -0800
> Actually I think this patch removes a choice from the user.
>
> Before this patch, the user can sniff all traffic by disabling vlans, or a
> specific vlan only by leaving vlans on when going into promisc mode.
>
> After this patch, the user has no choice but to sniff all vlans at all times.
>
> I don't think that that is such a good improvement.
I agree.
Look at the VLAN setting as being just like moving the
ethernet cable from one switch to another.
There is no logical difference.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists