| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200711130307.lAD37Nee045340@www262.sakura.ne.jp> Date: Tue, 13 Nov 2007 12:07:23 +0900 From: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp> To: akpm@...ux-foundation.org Cc: ebiederm@...ssion.com, linux-kernel@...r.kernel.org Subject: [PATCH] sysctl: Check length at deprecated_sysctl_warning. Andrew, please replace previous patch with this one. This one returns -ENOTDIR. ---------- Original patch forgot to check args->nlen. I don't know why args->nlen == CTL_MAXNAME is rejected, but it has been rejected traditionally. Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp> Cc: "Eric W. Biederman" <ebiederm@...ssion.com> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org> --- kernel/sysctl.c | 4 ++++ 1 file changed, 4 insertions(+) diff -puN kernel/sysctl.c~sysctl-check-length-at-deprecated_sysctl_warning kernel/sysctl.c --- a/kernel/sysctl.c~sysctl-check-length-at-deprecated_sysctl_warning +++ a/kernel/sysctl.c @@ -2609,6 +2609,10 @@ static int deprecated_sysctl_warning(str int name[CTL_MAXNAME]; int i; + /* Check args->nlen. */ + if (args->nlen <= 0 || args->nlen >= CTL_MAXNAME) + return -ENOTDIR; + /* Read in the sysctl name for better debug message logging */ for (i = 0; i < args->nlen; i++) if (get_user(name[i], args->name + i)) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists