[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200711151258.02696.eike-hotplug@sf-tec.de>
Date: Thu, 15 Nov 2007 12:57:56 +0100
From: Rolf Eike Beer <eike-hotplug@...tec.de>
To: Alex Chiang <achiang@...com>
Cc: Matthew Wilcox <matthew@....cx>, Gary Hade <garyhade@...ibm.com>,
Greg KH <greg@...ah.com>, gregkh@...e.de,
kristen.c.accardi@...el.com, lenb@...nel.org, rick.jones2@...com,
linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
kaneshige.kenji@...fujitsu.com,
pcihpd-discuss@...ts.sourceforge.net, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/5] Construct one fakephp slot per pci slot
Am Mittwoch, 14. November 2007 schrieb Alex Chiang:
> * Matthew Wilcox <matthew@....cx>:
> > On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang wrote:
> > > Register one slot per slot, rather than one slot per function.
> > > Change the name of the slot to fake%d instead of the pci address.
> > >
> > > +#define SLOT_NAME_SIZE KOBJ_NAME_LEN
> >
> > Defined, then never used ... how about s/KOBJ_NAME_LEN/8/, then use
> > SLOT_NAME_SIZE throughout?
>
> Whoops, good catch. I had a braino there.
Just drop it and use sizeof(dslot->name) in snprintf(). Just be careful not to
use slot->name there as it would always be sizeof(void*)!
Eike
Download attachment "signature.asc " of type "application/pgp-signature" (195 bytes)
Powered by blists - more mailing lists