linux-kernel - Re: [PATCH 2/5] Construct one fakephp slot per pci slot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071115174015.GI7541@ldl.fc.hp.com>
Date:	Thu, 15 Nov 2007 10:40:15 -0700
From:	Alex Chiang <achiang@...com>
To:	Rolf Eike Beer <eike-hotplug@...tec.de>
Cc:	Matthew Wilcox <matthew@....cx>, Gary Hade <garyhade@...ibm.com>,
	Greg KH <greg@...ah.com>, gregkh@...e.de,
	kristen.c.accardi@...el.com, lenb@...nel.org, rick.jones2@...com,
	linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
	kaneshige.kenji@...fujitsu.com,
	pcihpd-discuss@...ts.sourceforge.net, linux-acpi@...r.kernel.org
Subject: Re: [PATCH 2/5] Construct one fakephp slot per pci slot

* Rolf Eike Beer <eike-hotplug@...tec.de>:
> Am Mittwoch, 14. November 2007 schrieb Alex Chiang:
> > * Matthew Wilcox <matthew@....cx>:
> > > On Wed, Nov 14, 2007 at 12:37:29PM -0700, Alex Chiang
> > > > Register one slot per slot, rather than one slot per
> > > > function.  Change the name of the slot to fake%d instead
> > > > of the pci address.
> > > >
> > > > +#define SLOT_NAME_SIZE KOBJ_NAME_LEN
> > >
> > > Defined, then never used ... how about s/KOBJ_NAME_LEN/8/,
> > > then use SLOT_NAME_SIZE throughout?
> >
> > Whoops, good catch. I had a braino there.
> 
> Just drop it and use sizeof(dslot->name) in snprintf(). Just be
> careful not to use slot->name there as it would always be
> sizeof(void*)!

Thanks, even better.

/ac

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/