linux-kernel - Re: [PATCH v3 10/17] Remove some CFS specific code from the wakeup path of RT tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.58.0711171350510.12054@gandalf.stny.rr.com>
Date:	Sat, 17 Nov 2007 13:51:23 -0500 (EST)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Gregory Haskins <ghaskins@...ell.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <srostedt@...hat.com>,
	Christoph Lameter <clameter@....com>
Subject: Re: [PATCH v3 10/17] Remove some CFS specific code from the wakeup
 path of RT tasks


On Sat, 17 Nov 2007, Gregory Haskins wrote:

> >>> On Sat, Nov 17, 2007 at  1:21 AM, in message
> <20071117062404.672976284@...dmis.org>, Steven Rostedt <rostedt@...dmis.org>
> wrote:
>
> > +	 */
> > +	if (idle_cpu(cpu) || cpu_rq(cpu)->nr_running > 1)
> > +		return cpu;
> > +
> > +	for_each_domain(cpu, sd) {
> > +		if (sd->flags & SD_WAKE_IDLE) {
> > +			cpus_and(tmp, sd->span, p->cpus_allowed);
> > +			for_each_cpu_mask(i, tmp) {
> > +				if (idle_cpu(i))
> > +					return i;
>                                                                         ^^^^^^^^^^^^^^^^
>
> Looks like some stuff that was added in 24 was inadvertently lost in the move when you merged the patches up from 23.1-rt11.  The attached patch is updated to move the new logic as well.
>

Doh!  Good catch. Will rework on Monday.

-- Steve

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/