[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <473F9298.7060401@gmail.com>
Date: Sat, 17 Nov 2007 21:17:12 -0400
From: Kevin Winchester <kjwinchester@...il.com>
To: Andrew Morgan <morgan@...nel.org>
CC: Andrew Morton <akpm@...ux-foundation.org>, apw@...dowen.org,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
kamalesh@...ux.vnet.ibm.com
Subject: Re: 2.6.24-rc2-mm1 -- strange apparent network failures
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kevin Winchester wrote:
> Looking at the code being bypassed:
>
> if (pE.cap[i] || pP.cap[i] || pP.cap[i])
>
> looks somewhat weird as it is testing the same condition twice. Should
> it have been:
>
> if (pE.cap[i] || pP.cap[i] || pI.cap[i])
>
> ?
>
> I'm about to test that change instead of bypassing the loop, so I'll let
> you know the results.
>
No, this still results in a dead network connection, although it is
probably a correct change. I suppose giving the loop even more reasons
to return -ERANGE wasn't going to be helpful.
- --
Kevin Winchester
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFHP5KXKPGFQbiQ3tQRAilbAJ9h3qtO9sb9+ctVU0pxzCBjysy06QCdE1Wd
M5V3+0BWyn04p0UeUq/KSlw=
=663t
-----END PGP SIGNATURE-----
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists