[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20071120212031.GA157@tv-sign.ru>
Date: Wed, 21 Nov 2007 00:20:32 +0300
From: Oleg Nesterov <oleg@...sign.ru>
To: Roland McGrath <roland@...hat.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 1/2] kill PT_PTRACED
On 11/20, Roland McGrath wrote:
>
> Subject should be "kill PT_ATTACHED".
>
> > - (!(child->ptrace & PT_ATTACHED) || child->real_parent != current)
> > - && child->signal != NULL) {
> > + child->sighand != NULL) {
>
> This does s/signal/sighand/ without comment.
Ah yes, sorry, forgot to add the comment.
This is microoptimization, both ->signal and ->sighand are cleared at the same
time in __exit_signal(), so we can check either. But we are using the value of
->sighand below, so it makes sense to read ->sighand, not ->signal.
Andrew, it is very easy to send the new patch to fix the code, but is it possible
to fix the changelog somehow for the patch in -mm tree?
Oleg.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists