linux-kernel - Re: [PATCH -mm 1/2] kill PT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071120212851.EEB5026F8BE@magilla.localdomain>
Date:	Tue, 20 Nov 2007 13:28:51 -0800 (PST)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 1/2] kill PT_PTRACED

> This is microoptimization, both ->signal and ->sighand are cleared at the same
> time in __exit_signal(), so we can check either. But we are using the value of
> ->sighand below, so it makes sense to read ->sighand, not ->signal.

Ok.  Anality would suggest doing that in a separate patch, though I don't
really care.

> Andrew, it is very easy to send the new patch to fix the code, but is it
> possible to fix the changelog somehow for the patch in -mm tree?

I'd prefer a comment in the code there making it explicit that ->sighand is
a "reaped yet" synchronization check (under tasklist_lock).


Thanks,
Roland
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/