linux-kernel - Re: [PATCH] mct232: speed, new termios and compliance cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20071120220709.49b60de2@the-village.bc.nu>
Date:	Tue, 20 Nov 2007 22:07:09 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Pete Zaitcev <zaitcev@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	zaitcev@...hat.com
Subject: Re: [PATCH] mct232: speed, new termios and compliance cleanups

> >   * we do not know how to support. We ignore them for the moment.
> >   * XXX Rate-limit the error message, it's user triggerable.
> 
> This XXX item is fixed by this patch, so should be removed.

Ok

> 
> > +		/* FIXME: Can we use any divider - should we do
> > +		   divider = 115200/value;
> > +		   real baud = 115200/divider */
> >  		switch (value) {
> >  		case 300: break;
> 
> I do not understand this FIXME comment. What is wrong with current
> code? The result of the function is given to the device's sequencer.
> Do you want to get rid of the switch? Please unconfuse me.

What should happen ideally and I didnt have the hw to check is that
we take whatever baud rate the use requested (arbitary value). From that
we compute the best divider. From the best divider we compute the actual
speed. The actual speed is then written back into the termios structure.

(The kernel knows about a few percent off being ok and will report
appropriately in those cases)

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/