linux-kernel - Re: [PATCH] PPC: CHRP - fix possible NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20071123101646.63550945.sfr@canb.auug.org.au>
Date:	Fri, 23 Nov 2007 10:16:46 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Cyrill Gorcunov <gorcunov@...il.com>
Cc:	PPCML <linuxppc-dev@...abs.org>, Olof Johansson <olof@...om.net>,
	Paul Mackerras <paulus@...ba.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PPC: CHRP - fix possible NULL pointer dereference

On Thu, 22 Nov 2007 22:54:23 +0300 Cyrill Gorcunov <gorcunov@...il.com> wrote:
>
> This patch does fix possible NULL pointer dereference
> inside of strncmp() if of_get_property() failed.

Thanks for this.

>  static void __init sio_init(void)
>  {
>  	struct device_node *root;
> +	const char *model = NULL;

You don't need this initialization as you always assign the variable
before you use it.

> +	root = of_find_node_by_path("/");
> +	if (root) {

	if (!root)
		return;

would save a level of indentation. Not important.

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped