[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aa79d98a0711222023l31cdec98o47f56e3c87886a02@mail.gmail.com>
Date: Fri, 23 Nov 2007 07:23:54 +0300
From: "Cyrill Gorcunov" <gorcunov@...il.com>
To: "Stephen Rothwell" <sfr@...b.auug.org.au>
Cc: PPCML <linuxppc-dev@...abs.org>, "Olof Johansson" <olof@...om.net>,
"Paul Mackerras" <paulus@...ba.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PPC: CHRP - fix possible NULL pointer dereference
On 11/23/07, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> On Thu, 22 Nov 2007 22:54:23 +0300 Cyrill Gorcunov <gorcunov@...il.com>
> wrote:
> >
> > This patch does fix possible NULL pointer dereference
> > inside of strncmp() if of_get_property() failed.
>
> Thanks for this.
>
> > static void __init sio_init(void)
> > {
> > struct device_node *root;
> > + const char *model = NULL;
>
> You don't need this initialization as you always assign the variable
> before you use it.
>
> > + root = of_find_node_by_path("/");
> > + if (root) {
>
> if (!root)
> return;
>
> would save a level of indentation. Not important.
>
> --
> Cheers,
> Stephen Rothwell sfr@...b.auug.org.au
> http://www.canb.auug.org.au/~sfr/
>
Oh my :) Thanks. I'll fix it and resend.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists