linux-kernel - Re: [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20071126151926.GD28022@gondor.apana.org.au>
Date:	Mon, 26 Nov 2007 23:19:26 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	David Miller <davem@...emloft.net>, david-b@...bell.net,
	randy.dunlap@...cle.com, toralf.foerster@....de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [2.6 patch] ipv4/arp.c:arp_process(): remove bogus #ifdef mess

On Sun, Nov 25, 2007 at 04:30:03PM +0000, Adrian Bunk wrote:
> > > 
> > > Please look at net/ipv4/arp.c:arp_process()
> > > 
> > > Am I right that CONFIG_NET_ETHERNET=n and CONFIG_NETDEV_1000=y or 
> > > CONFIG_NETDEV_10000=y will not be handled correctly there?
> > > 
> > > And the best solution is to nuke all #ifdef's in this function and make 
> > > the code unconditionally available?
> > 
> > I think removing those specific ifdefs in arp_process()
> > is the best option, yes.
> 
> Patch below.

Thanks Adrian.  Patch applied to net-2.6.

Do we need this for stable too?

Chers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/